Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom field to the pilet package.json file for specifying pilet related meta data #34

Closed
lschoett opened this issue Jul 23, 2019 · 4 comments
Labels
enhancement New feature or request pilets Concerns the API of the pilets.
Milestone

Comments

@lschoett
Copy link
Contributor

New Feature Proposal

Description

A custom field should be added to the package.json file. The new field should be optional and transport meta data related to the given pilet. There should not be any content restriction applied to this field.

Background

Via the feed service, clients can be informed about custom attributes of the available pilets.

@lschoett lschoett added the enhancement New feature or request label Jul 23, 2019
@FlorianRappl FlorianRappl added the pilets Concerns the API of the pilets. label Jul 23, 2019
@FlorianRappl FlorianRappl added this to the 0.6.1 milestone Jul 23, 2019
@FlorianRappl
Copy link
Contributor

How should we name this field? Should we use this from the piral section that is already specified in the package.json?

My proposal:

{
  // ...
  "piral": {
    // ...
    "data": "Any Value of Any Type Here"
  }
}

If placing the field in the section piral is okay, but the name (data) is not, here are some suggestions:

  • info
  • custom
  • apiData
  • meta
  • rel

@FlorianRappl
Copy link
Contributor

Ok so current design proposal:

The key will always (to avoid confusions) be called custom. It will be appended in the Metadata from a feed service (by spec). It needs to be retrieved from the package.json of the pilet, which also refers to it (top-level) via custom. Hence piral will be left to the Piral CLI alone (which has no impact for the feed service).

FlorianRappl added a commit that referenced this issue Jul 25, 2019
@FlorianRappl
Copy link
Contributor

Landed in develop.

@FlorianRappl
Copy link
Contributor

FlorianRappl commented Jul 25, 2019

Leaving it open for feedback.

Feedback is possible until 0.6.1 is merged. ETA for 0.6.1 is tomorrow (Friday, 26th of July noonish CET).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request pilets Concerns the API of the pilets.
Projects
None yet
Development

No branches or pull requests

2 participants