Fix certificate inspect #1153
Merged
Fix certificate inspect #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs triage
dopey
force-pushed
the
max/go-dep-updates
branch
from
e16d9e6 to
12e3dbc
Compare
maraino
reviewed
Apr 16, 2024
command/certificate/inspect.go
Outdated
| blocks = append(blocks, block) | ||
| crts, err := pemutil.ReadCertificateBundle(crtFile) | ||
| switch { | ||
| case errors.As(err, &pemutil.ErrNoValidPEMCert): |
There was a problem hiding this comment.
See my other PR where you can use Is.
- Pull in updated go.step.sm/crypto with improved parsing for PEM formatted CSR and certificate files - Allows for ignoring extraneous data in PEM files
dopey
force-pushed
the
max/go-dep-updates
branch
from
12e3dbc to
8d4311a
Compare
maraino
previously approved these changes
Apr 22, 2024
dopey
force-pushed
the
max/go-dep-updates
branch
from
6a48314 to
08f3cbe
Compare
maraino
approved these changes
Apr 22, 2024
redrac
pushed a commit
to redrac/smallstep-cli
that referenced
this pull request
May 3, 2024
* Pull in updated go.step.sm/crypto with improved parsing for PEM formatted CSR and certificate files - Allows for ignoring extraneous data in PEM files * go mod tidy * Removed unused derToPemBlock helper function * Update changelog | allow certificate inspect to output CSR in PEM format * Add unit tests for inspectCertificateRequest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.