Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK should update certificate pools safely #27

Merged
merged 11 commits into from
Feb 7, 2019
Merged

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Jan 23, 2019

Description

Certificate pools should be safely updated when root or federation certificates are rotated. A server uses tls.Config.GetConfigForClient to provide the refreshed version of the tls.Config while clients use a custom http.Transport.DialTLS that uses the refreshed tls.Config. Fixes #23

This PR also adds the method BootstrapListener that creates a net.Listener configured with the TLS certificate provided by the CA

@maraino maraino requested a review from dopey January 23, 2019 22:41
ca/bootstrap_test.go Outdated Show resolved Hide resolved
ca/mutable_tls_config.go Outdated Show resolved Hide resolved
ca/mutable_tls_config.go Outdated Show resolved Hide resolved
ca/mutable_tls_config.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #27 into master will increase coverage by 2.1%.
The diff coverage is 85.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #27     +/-   ##
=========================================
+ Coverage   76.59%   78.69%   +2.1%     
=========================================
  Files          20       21      +1     
  Lines        1658     1953    +295     
=========================================
+ Hits         1270     1537    +267     
- Misses        276      298     +22     
- Partials      112      118      +6
Impacted Files Coverage Δ
ca/mutable_tls_config.go 100% <100%> (ø)
ca/client.go 77.03% <33.33%> (+6.95%) ⬆️
ca/bootstrap.go 71.42% <60%> (-3.58%) ⬇️
ca/tls.go 67.78% <81.81%> (+0.88%) ⬆️
ca/tls_options.go 94.07% <84%> (-5.93%) ⬇️
authority/tls.go 70.87% <0%> (+0.81%) ⬆️
authority/claims.go 85.5% <0%> (+1.06%) ⬆️
authority/types.go 97.22% <0%> (+1.14%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88a3c4c...e0fff4d. Read the comment docs.

ca/mutable_tls_config.go Outdated Show resolved Hide resolved
ca/mutable_tls_config.go Outdated Show resolved Hide resolved
ca/tls.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few comments about grammar / syntax

@maraino maraino merged commit 262a9d0 into master Feb 7, 2019
@maraino maraino deleted the mariano/renew-pool branch February 7, 2019 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants