-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDK should update certificate pools safely #27
Conversation
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
=========================================
+ Coverage 76.59% 78.69% +2.1%
=========================================
Files 20 21 +1
Lines 1658 1953 +295
=========================================
+ Hits 1270 1537 +267
- Misses 276 298 +22
- Partials 112 118 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few comments about grammar / syntax
Description
Certificate pools should be safely updated when root or federation certificates are rotated. A server uses
tls.Config.GetConfigForClient
to provide the refreshed version of the tls.Config while clients use a custom http.Transport.DialTLS that uses the refreshed tls.Config. Fixes #23This PR also adds the method
BootstrapListener
that creates anet.Listener
configured with the TLS certificate provided by the CA