Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use go 1.13 to build certificates #214

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Use go 1.13 to build certificates #214

merged 2 commits into from
Mar 24, 2020

Conversation

maraino
Copy link
Contributor

@maraino maraino commented Mar 24, 2020

Description

Use go 1.13 to build certificates, tests are probably hanging due to golang/go#38023

@codecov-io
Copy link

Codecov Report

Merging #214 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #214      +/-   ##
==========================================
- Coverage   73.85%   73.81%   -0.05%     
==========================================
  Files          75       75              
  Lines        8546     8544       -2     
==========================================
- Hits         6312     6307       -5     
- Misses       1908     1913       +5     
+ Partials      326      324       -2     
Impacted Files Coverage Δ
ca/tls.go 64.37% <ø> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3480ed4...1d7ab91. Read the comment docs.

@maraino maraino requested a review from dopey March 24, 2020 22:02
Copy link
Contributor

@dopey dopey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@maraino maraino merged commit 83993d3 into master Mar 24, 2020
@maraino maraino deleted the build-with-go.1.13 branch March 24, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants