-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add authority option WithX509SignerFunc #874
Comments
Maybe it should return an |
@francislavoie what do you think would be the behavior if there's an error? fail or use a cached version of the intermediate and signer? |
I'd think fail the current operation 🤷♂️ |
To elaborate, currently for Caddy I think it wouldn't be possible to return an error for the intermediate cert, but if we moved the "sign with root" behaviour into the func then it could error technically because it would have to reload it from disk. But I think what we'd probably do is use |
This change adds a new authority option that allows to pass a callback that returns the certificate chain and signer used to sign X.509 certificates. This option will be used by Caddy, they renew the intermediate certificate weekly and there's no other way to replace it without re-creating the embedded CA. Fixes #874
@francislavoie, @mholt |
Yeah, looks great to me! Thanks!! |
Description
Caddy proposes adding a new function to be able to automatically replace the intermediate certificate in an authority using a function that returns the current certificate chain and signer to use. See caddyserver/caddy#4517.
The new option can be something like
Then
SoftCAS
if configured can use that to get the updated chain and signer.The text was updated successfully, but these errors were encountered: