Use user passed values instead of hardcoding #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cescoffier
previously approved these changes
Oct 18, 2024
aureamunoz
force-pushed
the
fix-eureka-hardcoding
branch
from
205eb31 to
42c15fd
Compare
|
Can you squash ? |
aureamunoz
force-pushed
the
fix-eureka-hardcoding
branch
from
92db9b0 to
b1360bc
Compare
aureamunoz
force-pushed
the
fix-eureka-hardcoding
branch
from
72f8e71 to
38542b8
Compare
cescoffier
approved these changes
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.