Expose selected instance #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aureamunoz can you rebase from |
I did it and resolve a few conflicts. I will squash them |
aureamunoz
force-pushed
the
expose-selected-instance
branch
from
214f7d1 to
8274991
Compare
|
I still see 8 commits. That looks weird. |
cescoffier
requested changes
Sep 22, 2023
api/src/main/java/io/smallrye/stork/api/observability/ObservationPoints.java
Outdated
Show resolved
Hide resolved
aureamunoz
force-pushed
the
expose-selected-instance
branch
from
f18c076 to
d238d83
Compare
aureamunoz
force-pushed
the
observability
branch
from
fe03d54 to
71e8ef1
Compare
aureamunoz
force-pushed
the
expose-selected-instance
branch
from
92f66fb to
4ef6edc
Compare
|
I think now is ok. I needed to rebase onto main also observability branch. Are you ok with it @cescoffier ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.