Bump io.smallrye.config:smallrye-config from 3.3.4 to 3.4.1 #2312
Conversation
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
dependabot
bot
added
dependencies
|
Still failing our environment property tests: |
|
(as for the previous one, do not update Quarkus until we have a way to support the same behavior) |
|
The test is failing with mixed mode env vars like I'll fix the code here. |
Bumps [io.smallrye.config:smallrye-config](https://github.com/smallrye/smallrye-config) from 3.3.4 to 3.4.1. - [Release notes](https://github.com/smallrye/smallrye-config/releases) - [Commits](smallrye/smallrye-config@3.3.4...3.4.1) --- updated-dependencies: - dependency-name: io.smallrye.config:smallrye-config dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
radcortez
force-pushed
the
dependabot/maven/main/io.smallrye.config-smallrye-config-3.4.1
branch
from
71ec9f6 to
9b697cf
Compare
|
I have updated the assertion to accept the mixed env var case. I don't think this is a breaking change. |
| @@ -126,7 +126,7 @@ public void testGetFromEnv() { | |||
| assertThat(config.getOptionalValue("ATTR4", String.class)).hasValue("used-2"); | |||
| // Mixed case value in env should not be found as it does not match the key we're looking for | |||
| // either in its original casing, or after conversion to uppercase. | |||
| assertThat(config.getOptionalValue("mixedcase", String.class)).isEmpty(); | |||
| assertThat(config.getOptionalValue("mixedcase", String.class)).hasValue("used"); | |||
There was a problem hiding this comment.
That's a change of behavior.
I'm not sure we can accept this blindly. It's a breaking change; if we have that test, it's because it got reported. So, we are going to break at least one app.
There was a problem hiding this comment.
The assert history is coming from the original commit in https://github.com/smallrye/smallrye-reactive-messaging/pull/1017/files#diff-9826df505660d404d63487cb621c216c80b55e45ad50f25a3f93a944fc634565R26, so it doesn't seem it was added on purpose by someone that reported that.
Consider the following:
FOO_bar_BAZ=1234The previous implementation would match the env var with the following properties:
FOO.bar.BAZ
FOO_bar_BAZ
FOO_BAR_BAZThe new implementation matches:
foo.bar.baz
FOO.bar.BAZ
FOO_bar_BAZ
FOO_BAR_BAZIn my opinion, it doesn't make sense to match FOO.bar.BAZ and don't match foo.bar.baz. Effectively, they have the same semantic meaning.
Yes, I know that Env vars are case sensitive, but that something that the spec doesn't seem to care about. If that was the case, then FOO_BAR_BAZ shouldn't match.
There was a problem hiding this comment.
Ah got it! So, yes, it's better now.
I thought it was something that was handled and became unhandled.
ozangunalp
deleted the
dependabot/maven/main/io.smallrye.config-smallrye-config-3.4.1
branch
Bumps io.smallrye.config:smallrye-config from 3.3.4 to 3.4.1.
Release notes
Sourced from io.smallrye.config:smallrye-config's releases.
Commits
05624a0[maven-release-plugin] prepare release 3.4.1f75c675Release 3.4.1 (#1019)673a0d3Update SmallRye Commons to 2.2.0 (#1017)97bcfd0Single StringBuilder allocation per find (#1016)7624248Match and replace semantic property names in the EnvConfigSource (#1014)1810643Clarify SmallRyeConfigBuilderCustomizer priority javadocse5bdb10Do not override defaults set by the builder with mappings (#1013)1294b93Bump io.smallrye:smallrye-parent from 40 to 41 (#1012)c00f8f0Create next milesone1876df5[maven-release-plugin] prepare for next development iterationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)