Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ - Fix RabbitMQ consumer leak #2184

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

cescoffier
Copy link
Contributor

The consumers were not canceled (closed) during the application termination, leading to connections piling up on the broker.

Related to quarkusio/quarkus#33698.

The consumers were not cancelled (closed) during the application termination, leading to connection pilling up on the broker.
@cescoffier cescoffier requested a review from ozangunalp June 12, 2023 08:45
@cescoffier cescoffier changed the title Fix RabbitMQ consumer leak RabbitMQ - Fix RabbitMQ consumer leak Jun 12, 2023
@cescoffier cescoffier added rabbitmq bug Something isn't working labels Jun 12, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #2184 (9ec265d) into main (97afce1) will decrease coverage by 65.79%.
The diff coverage is 0.00%.

❗ Current head 9ec265d differs from pull request most recent head 17ea389. Consider uploading reports for the commit 17ea389 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##               main    #2184       +/-   ##
=============================================
- Coverage     77.53%   11.75%   -65.79%     
+ Complexity     3635      457     -3178     
=============================================
  Files           299      299               
  Lines         12139    12149       +10     
  Branches       1550     1550               
=============================================
- Hits           9412     1428     -7984     
- Misses         2011    10535     +8524     
+ Partials        716      186      -530     
Impacted Files Coverage Δ
...ive/messaging/providers/helpers/KeyMultiUtils.java 0.00% <0.00%> (-83.34%) ⬇️
...reactive/messaging/rabbitmq/RabbitMQConnector.java 0.00% <0.00%> (-88.95%) ⬇️
...e/messaging/test/common/config/MapBasedConfig.java 0.00% <0.00%> (-75.61%) ⬇️

... and 249 files with indirect coverage changes

@ozangunalp ozangunalp merged commit b8bdc3a into smallrye:main Jun 12, 2023
@cescoffier cescoffier deleted the fix-rabbitmq-consumer-leak branch June 20, 2023 05:57
@cescoffier cescoffier added this to the 4.7.0 milestone Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working rabbitmq
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants