Detect static file format when parsing #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
reviewed
Nov 8, 2024
core/src/main/java/io/smallrye/openapi/api/SmallRyeOpenAPI.java
Outdated
Show resolved
Hide resolved
Azquelt
commented
Nov 8, 2024
core/src/main/java/io/smallrye/openapi/api/SmallRyeOpenAPI.java
Outdated
Show resolved
Hide resolved
Ensure that an openapi.json file is parsed as JSON, rather than as YAML.
Azquelt
force-pushed
the
static-file-format
branch
2 times, most recently
from
f4a68be to
82d6039
Compare
Test we correctly load a JSON static file. This test will fail if we try to parse the JSON as YAML.
Azquelt
commented
Nov 8, 2024
Azquelt
force-pushed
the
static-file-format
branch
from
82d6039 to
e642544
Compare
|
Ok, I think I'm happy with it. This is ready to be merged once it's built and reviewed. |
|
MikeEdgar
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that an openapi.json file is parsed as JSON, rather than as YAML.
This still needs a test adding.
Fixes #2059