Additional type checks in models and Json/YAML reader

[MikeEdgar]

No description provided.

[MikeEdgar]

@Azquelt - fyi

[Azquelt]

This is definitely better.

It does still have one change in behaviour for Schema.

If I read in a schema like this:

{
    "type": "object",
    "properties": ["id", "name"]
}

The properties field is dropped when reading because it's not a map, which wasn't the case in alpha6.

Using the Schema.set(String, Object), I can set properties to whatever I want, it only gets dropped during reading.

This does slightly affect our ability to pass through a schema object we don't understand untouched. I've written some tests to demonstrate the change in behaviour here: Azquelt@0e17e6b - with these changes testSchemas_InvalidTypes is the only one that doesn't pass.

[MikeEdgar]

The properties field is dropped when reading because it's not a map, which wasn't the case in alpha6.

Using the Schema.set(String, Object), I can set properties to whatever I want, it only gets dropped during reading.

This does slightly affect our ability to pass through a schema object we don't understand untouched. I've written some tests to demonstrate the change in behaviour here: Azquelt@0e17e6b - with these changes testSchemas_InvalidTypes is the only one that doesn't pass.

I've added an additional fallback for Schema where it will read any type for the property. The last push also includes your commit cherry-picked to this PR (if that's ok 😃)

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
84.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Azquelt]

These changes look good to me. There were a few other small changes in behaviour which needed tweaks in OpenLiberty (noted on #2021), but now I have all my tests passing.

[MikeEdgar]

@phillip-kruger some additional fixes for 4.0. Please take a look when you can.