Update openapi version string #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@benjamin-confino I think this should target the |
benjamin-confino
force-pushed
the
update-openapi-version-string
branch
from
30576ae to
9e85aed
Compare
|
I'm marking this as a draft until #1801 is delivered, otherwise it will cause a merge conflict in that more important PR. When 1801 is in I'll deal with the merging myself. |
benjamin-confino
force-pushed
the
update-openapi-version-string
branch
3 times, most recently
from
7627bcf to
fa4512a
Compare
MikeEdgar
requested changes
May 9, 2024
core/src/main/java/io/smallrye/openapi/runtime/io/schema/SchemaConstant.java
Outdated
Show resolved
Hide resolved
.../gradle-plugin/src/test/java/io/smallrye/openapi/gradleplugin/SmallryeOpenApiPluginTest.java
Outdated
Show resolved
Hide resolved
Indeed they were not. I did a text search for the filenames and found no reference to them, then I tested without the files and nothing complained. |
benjamin-confino
force-pushed
the
update-openapi-version-string
branch
2 times, most recently
from
390f6bd to
01aa1e0
Compare
MikeEdgar
requested changes
May 10, 2024
.../gradle-plugin/src/test/java/io/smallrye/openapi/gradleplugin/SmallryeOpenApiPluginTest.java
Outdated
Show resolved
Hide resolved
.../gradle-plugin/src/test/java/io/smallrye/openapi/gradleplugin/SmallryeOpenApiPluginTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/smallrye/openapi/runtime/util/TypeUtil.java
Outdated
Show resolved
Hide resolved
benjamin-confino
force-pushed
the
update-openapi-version-string
branch
from
01aa1e0 to
e6fc7c4
Compare
benjamin-confino
force-pushed
the
update-openapi-version-string
branch
from
e6fc7c4 to
2da5645
Compare
|
I've merged the latest comments and rebaesd on integration. |
MikeEdgar
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will keep us in line with eclipse/microprofile-open-api#434