Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose annotated XML attributes/elements when XmlAccessorType is NONE #1505

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

MikeEdgar
Copy link
Member

Fixes #1504

@MikeEdgar MikeEdgar added this to the 3.4.1 milestone Jun 30, 2023
@MikeEdgar MikeEdgar requested a review from phillip-kruger June 30, 2023 21:13
@phillip-kruger phillip-kruger enabled auto-merge July 3, 2023 00:57
@phillip-kruger phillip-kruger disabled auto-merge July 3, 2023 00:58
@phillip-kruger phillip-kruger merged commit 0093d09 into smallrye:main Jul 3, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jul 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MikeEdgar MikeEdgar deleted the issue-1504 branch July 3, 2023 10:56
@troosan
Copy link

troosan commented Jul 8, 2023

@MikeEdgar There is an issue when the name in the XmlElement does not match the method name
image

it then returns
image

@troosan
Copy link

troosan commented Jul 8, 2023

Also the XmlType.name does not seem to be taken into account
image

The order of the elements is not respected when the bean name does not match the XmlElement.name
there is a unit test for that though (TypeResolverTests.testJavaxJaxbCustomPropertyOrder) ... so I'm not sure what's wrong.

I have updated https://github.com/troosan/quarkus-jaxb-openapi-reproducer to reproduce this

@troosan
Copy link

troosan commented Jul 8, 2023

the good new though is that the change seems to be compatible with 2.x (except for the Annotations class that was added later and which I had to change back to TypeUtil

@MikeEdgar
Copy link
Member Author

Thanks for reporting this @troosan . It seems the XML support can be improved a bit. Would you mind putting your findings about the missing name support into a new issue?

@troosan
Copy link

troosan commented Jul 10, 2023

Thanks for reporting this @troosan . It seems the XML support can be improved a bit. Would you mind putting your findings about the missing name support into a new issue?

done, see #1510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XML attributes/elements ignored when class is annotated with XmlAccessType.NONE
3 participants