Upgrade to Jandex 3.0.0 #1232
Merged
Upgrade to Jandex 3.0.0 #1232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, if you wanna take the first 3 commits from this PR and push them to 2.3.x directly, that would be fine with me :-) Or any other way you wish, of course. |
|
@Ladicek , this is good, thank you. Please go ahead and close the 3.0.x and 2.2.x PRs and I'll update the main PR and this with the changes for type references. A 3.0-RC is manually generated each time a release of 2.x occurs, with only the Jakarta changes applied with the |
|
PRs to 2.2.x and 3.0x closed, thank you! |
MikeEdgar
force-pushed
the
jandex3-2.3.x
branch
from
a2474b2 to
96bf53a
Compare
MikeEdgar
force-pushed
the
jandex3-2.3.x
branch
from
96bf53a to
7b60e07
Compare
MikeEdgar
approved these changes
Sep 5, 2022
|
SonarCloud Quality Gate failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed someone created the 2.3.x branch, but it was branched off of the 2.2.0 tag, which I believe is not right. So this PR, targeting the 2.3.x branch:
[maven-release-plugin] prepare for next development iteration);<tag>element in the POM, as that should readHEADoutside of release commits;<version>elements to say2.3.0-SNAPSHOT;With this PR merged to current 2.3.x (which points to a6d1ad5), I believe the 2.3.x branch would be in the correct state. Next, we would close #1227 (as we want to keep 2.2.x on Jandex 2.x). We could also close #1228, if 3.0.x is really automatically created from 2.2.x -- I believe we would actually also move 3.0.x to be based on 2.3.x.
Makes sense, or do I completely misunderstand how SmallRye OpenAPI is managed? Thank you!