Do not set nullable: false due to Bean Validation annotations
#1181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeEdgar
commented
Jul 14, 2022
| @@ -274,7 +273,7 @@ | |||
| "properties": { | |||
| "title": { | |||
| "type": "string", | |||
| "nullable": false | |||
| "nullable": true | |||
There was a problem hiding this comment.
Field type is Optional, resulting in the true
MikeEdgar
force-pushed
the
1180_remove_nullable_from_bv
branch
from
28bc0e2 to
d3377a3
Compare
Signed-off-by: Michael Edgar <[email protected]>
MikeEdgar
force-pushed
the
1180_remove_nullable_from_bv
branch
from
d3377a3 to
b606284
Compare
|
@phillip-kruger let me know if this looks OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1180
Nullable of
falseis the default assumed value in OpenAPI 3