Solves #1166 #1179
Merged
Solves #1166 #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phillip-kruger
requested changes
Jul 13, 2022
| @@ -49,6 +49,7 @@ E.g. for includeDependenciesScopes could be configured as: | |||
| - `configProperties` (String) - Load any properties from a file. Example `${basedir}/src/main/resources/application.properties`. | |||
| - `attachArtifacts` (boolean, default: false) - Attach the built OpenAPI schema as build artifact. | |||
| - `skip` (boolean, default: false) - Skip execution of the plugin. | |||
| - `encoding` (String) - Encoding of output OpenAPI files. | |||
There was a problem hiding this comment.
We can probably make the default UTF-8 to stay backward compatible ?
There was a problem hiding this comment.
@phillip-kruger, I thought the same thing, but previously it was using String#getBytes, which internally calls Charset.defaultCharset.
There was a problem hiding this comment.
Ok, but it should still be able to do this. Not sure if you can make these properties Optional ? If so , use Optional with empty setting to default
There was a problem hiding this comment.
The default defaultValue in the @Parameter is an empty string. That flows into the (!StringUtils.isBlank(encoding)) check and then uses the platform default encoding.
| /** | ||
| * Output encoding for openapi document. | ||
| */ | ||
| @Parameter(property = "encoding") |
There was a problem hiding this comment.
So here defaultValue = "UTF-8"
MikeEdgar
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added encoding as parameter to set output file encoding