Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: timing issue in MultiOnSubscribeCall where the Multi could terminate before the Uni #1693

Merged
merged 2 commits into from
Oct 2, 2024

Conversation

jponge
Copy link
Member

@jponge jponge commented Oct 2, 2024

Fixes #1678

@jponge jponge added this to the 2.7.0 milestone Oct 2, 2024
@jponge jponge requested a review from cescoffier October 2, 2024 16:54
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 3 lines in your changes missing coverage. Please review.

Project coverage is 89.44%. Comparing base (97f75a4) to head (9591080).
Report is 229 commits behind head on main.

Files with missing lines Patch % Lines
...e/mutiny/operators/multi/MultiOnSubscribeCall.java 92.30% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1693      +/-   ##
============================================
+ Coverage     89.41%   89.44%   +0.02%     
+ Complexity     3275     3271       -4     
============================================
  Files           457      457              
  Lines         13264    13301      +37     
  Branches       1642     1649       +7     
============================================
+ Hits          11860    11897      +37     
- Misses          788      789       +1     
+ Partials        616      615       -1     
Files with missing lines Coverage Δ
...e/mutiny/operators/multi/MultiOnSubscribeCall.java 87.71% <92.30%> (+4.38%) ⬆️

... and 11 files with indirect coverage changes

addSuppressed might throw an exception (in theory), so a try/finally is a safer option.
@jponge jponge enabled auto-merge October 2, 2024 19:54
@jponge jponge merged commit 01c6a3e into smallrye:main Oct 2, 2024
8 checks passed
@jponge jponge deleted the fix/1678 branch October 2, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible timing bug with onSubscription().call()
2 participants