Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: race condition on cancellation in UniCallbackSubscriber #1495

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Conversation

jponge
Copy link
Member

@jponge jponge commented Jan 23, 2024

Fixes #1494

@jponge jponge requested a review from cescoffier January 23, 2024 14:51
@jponge jponge added this to the 2.5.5 milestone Jan 23, 2024
@jponge jponge added the bug Something isn't working label Jan 23, 2024
@jponge
Copy link
Member Author

jponge commented Jan 23, 2024

/cc @DavideD

@jponge jponge enabled auto-merge January 23, 2024 14:59
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dded2d6) 89.34% compared to head (be54f15) 89.13%.
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1495      +/-   ##
============================================
- Coverage     89.34%   89.13%   -0.21%     
+ Complexity     3365     3355      -10     
============================================
  Files           459      459              
  Lines         13434    13435       +1     
  Branches       1635     1636       +1     
============================================
- Hits          12002    11975      -27     
- Misses          808      821      +13     
- Partials        624      639      +15     
Files Coverage Δ
...smallrye/mutiny/helpers/UniCallbackSubscriber.java 84.61% <100.00%> (+15.38%) ⬆️
...llrye/mutiny/operators/multi/MultiConcatMapOp.java 87.41% <100.00%> (+0.08%) ⬆️

... and 11 files with indirect coverage changes

@jponge jponge merged commit d0e0f8d into main Jan 23, 2024
7 checks passed
@jponge jponge deleted the fix/1494 branch January 23, 2024 15:09
@DavideD
Copy link

DavideD commented Jan 23, 2024

That was quick, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition on UniCallbackSubscriber cancellation
3 participants