Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: rewrite of the concatenation operators #1467

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Conversation

jponge
Copy link
Member

@jponge jponge commented Dec 14, 2023

Reverts b552fc4, we will eventually need to come back to rewriting this operator.

Reverts b552fc4, we will eventually need to come back to rewriting this operator.
@jponge jponge added the bug Something isn't working label Dec 14, 2023
@jponge jponge added this to the 2.5.3 milestone Dec 14, 2023
@jponge jponge linked an issue Dec 14, 2023 that may be closed by this pull request
@jponge
Copy link
Member Author

jponge commented Dec 14, 2023

/cc @ozangunalp if you can check against Reactive Messaging before I proceed to a 2.5.3 release 🙏

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #1467 (87a4eb3) into main (c59be05) will decrease coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 84.46%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1467      +/-   ##
============================================
- Coverage     89.32%   89.22%   -0.10%     
  Complexity     3362     3362              
============================================
  Files           459      459              
  Lines         13402    13399       -3     
  Branches       1641     1640       -1     
============================================
- Hits          11971    11955      -16     
- Misses          797      814      +17     
+ Partials        634      630       -4     
Files Coverage Δ
...llrye/mutiny/operators/multi/MultiConcatMapOp.java 82.40% <84.46%> (-3.54%) ⬇️

... and 12 files with indirect coverage changes

Copy link
Collaborator

@ozangunalp ozangunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jponge jponge merged commit 1a8fd00 into main Dec 14, 2023
7 checks passed
@jponge jponge deleted the revert/concatMap-rewrite branch December 14, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race-condition in the new concatMap operator
2 participants