Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the MultiSubscribe operator implementation #1257

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

jponge
Copy link
Member

@jponge jponge commented Apr 21, 2023

  • Reuse more of the super class defaults
  • Account for later cancellation

- Reuse more of the super class defaults
- Account for later cancellation
@jponge jponge added the technical-debt Technical debt reduction label Apr 21, 2023
@jponge jponge added this to the 2.2.0 milestone Apr 21, 2023
@jponge jponge requested a review from cescoffier April 21, 2023 09:38
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #1257 (c04f32a) into main (a44539f) will increase coverage by 0.14%.
The diff coverage is 78.57%.

❗ Current head c04f32a differs from pull request most recent head 74b435a. Consider uploading reports for the commit 74b435a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1257      +/-   ##
============================================
+ Coverage     89.49%   89.63%   +0.14%     
- Complexity     3341     3349       +8     
============================================
  Files           458      458              
  Lines         13234    13231       -3     
  Branches       1650     1650              
============================================
+ Hits          11844    11860      +16     
+ Misses          721      716       -5     
+ Partials        669      655      -14     
Impacted Files Coverage Δ
...rye/mutiny/operators/multi/MultiSubscribeOnOp.java 88.88% <78.57%> (+2.22%) ⬆️

... and 12 files with indirect coverage changes

@cescoffier cescoffier merged commit 62b9a26 into main Apr 21, 2023
@cescoffier cescoffier deleted the internal/simplify-multi-subscribe-on-op branch April 21, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical-debt Technical debt reduction
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants