Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Javadoc of UniCombine.any() #1128

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

acanda
Copy link
Contributor

@acanda acanda commented Nov 23, 2022

Remove the duplicated "a failure" in "... fires an item or a failure a failure, ...".

Remove the duplicated "a failure" in "... fires an item or a failure a failure, ...".
@cescoffier
Copy link
Contributor

Good catch!

@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Merging #1128 (3628618) into main (05aa570) will increase coverage by 0.12%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1128      +/-   ##
============================================
+ Coverage     89.57%   89.70%   +0.12%     
- Complexity     3336     3343       +7     
============================================
  Files           458      458              
  Lines         13220    13220              
  Branches       1644     1644              
============================================
+ Hits          11842    11859      +17     
+ Misses          713      701      -12     
+ Partials        665      660       -5     
Impacted Files Coverage Δ
...ain/java/io/smallrye/mutiny/groups/UniCombine.java 100.00% <ø> (ø)
...tiny/operators/multi/MultiBufferWithTimeoutOp.java 73.10% <0.00%> (-1.69%) ⬇️
...lrye/mutiny/operators/uni/builders/UniJoinAll.java 94.44% <0.00%> (-1.39%) ⬇️
...io/smallrye/mutiny/operators/uni/UniMemoizeOp.java 89.32% <0.00%> (-0.98%) ⬇️
...mallrye/mutiny/operators/multi/MultiFlatMapOp.java 90.36% <0.00%> (+1.99%) ⬆️
.../io/smallrye/mutiny/helpers/queues/DrainUtils.java 77.77% <0.00%> (+2.22%) ⬆️
...ny/operators/uni/builders/UniCreateFromFuture.java 91.80% <0.00%> (+3.27%) ⬆️
...lrye/mutiny/subscription/SerializedSubscriber.java 85.32% <0.00%> (+5.50%) ⬆️
...perators/multi/processors/SerializedProcessor.java 91.08% <0.00%> (+5.94%) ⬆️

@jponge
Copy link
Member

jponge commented Nov 23, 2022

Thanks @acanda

@jponge jponge added the documentation Improvements or additions to documentation label Nov 23, 2022
@jponge jponge added this to the 2.0.0 milestone Nov 23, 2022
@jponge jponge merged commit 04988f6 into smallrye:main Nov 23, 2022
@acanda acanda deleted the fix/unicombine-any-javadoc branch November 23, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants