Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer a variant of Uni::eventually(uni) that handles cancellation #1742

Closed
jponge opened this issue Nov 20, 2024 · 0 comments · Fixed by #1743
Closed

Offer a variant of Uni::eventually(uni) that handles cancellation #1742

jponge opened this issue Nov 20, 2024 · 0 comments · Fixed by #1743
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jponge
Copy link
Member

jponge commented Nov 20, 2024

Uni::eventually(uni) is currently a shortcut to onItemOrFailure()::call but it doesn't handle the termination / cancellation cases.
@jponge jponge added enhancement New feature or request good first issue Good for newcomers labels Nov 20, 2024
jponge added a commit to jponge/smallrye-mutiny that referenced this issue Nov 20, 2024
@jponge
fix!(Uni): align the Uni::eventually operators to onTermination() sem…
c447ab5 
…antics

The Uni::eventually(Runnable) operator had been previously moved from onItemOrFailure() to
onTermination() semantics so as to handle cancellation on top of already handling items and
failures.

This aligns the `eventually(Supplier<Uni<T>>)` variant with its `eventually(Runnable)`
counterpart.

Fixes smallrye#1742.

BREAKING CHANGE: this may break code bases where onItemOrFailure() semantics were correctly assumed and cancellation was handled separately.
@jponge jponge mentioned this issue Nov 20, 2024
Merged
jponge added a commit to jponge/smallrye-mutiny that referenced this issue Nov 20, 2024
@jponge
fix!(Uni): align the Uni::eventually operators to onTermination() sem…
2199d13 
…antics

The Uni::eventually(Runnable) operator had been previously moved from onItemOrFailure() to
onTermination() semantics so as to handle cancellation on top of already handling items and
failures.

This aligns the `eventually(Supplier<Uni<T>>)` variant with its `eventually(Runnable)`
counterpart.

Fixes smallrye#1742.

BREAKING CHANGE: this may break code bases where onItemOrFailure() semantics were correctly
assumed and cancellation was handled separately.
@jponge jponge closed this as completed in 54a161d Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Align the Uni::eventually operators to onTermination() semantics jponge/smallrye-mutiny
1 participant
@jponge