Skip to content

Commit

Permalink
Update Parent to 38
Browse files Browse the repository at this point in the history
  • Loading branch information
radcortez committed Oct 16, 2024
1 parent 55381b5 commit 17d0d63
Show file tree
Hide file tree
Showing 9 changed files with 32 additions and 143 deletions.
Binary file removed .github/release/maven-settings.xml.gpg
Binary file not shown.
Binary file removed .github/release/smallrye-sign.asc.gpg
Binary file not shown.
35 changes: 8 additions & 27 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ name: SmallRye Build
on:
push:
branches:
- main
- jakarta
- micrometer
- 4.x
paths-ignore:
- '.gitignore'
- 'CODEOWNERS'
Expand All @@ -25,17 +23,20 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
java: [11, 17]
java: [11, 17, 21]
name: build with jdk ${{matrix.java}}

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
name: checkout

- uses: actions/setup-java@v1
- uses: actions/setup-java@v4
name: set up jdk ${{matrix.java}}
with:
distribution: 'temurin'
java-version: ${{matrix.java}}
cache: 'maven'
cache-dependency-path: '**/pom.xml'

- name: build with maven
run: mvn -B formatter:validate verify --file pom.xml
Expand All @@ -44,24 +45,4 @@ jobs:
name: tck-report
with:
name: tck-report
path: testsuite/tck/target/surefire-reports

quality:
needs: [build]
if: github.event_name == 'push' && github.repository_owner == 'smallrye'
runs-on: ubuntu-latest
name: quality

steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: actions/setup-java@v1
with:
java-version: 11

- name: sonar
env:
GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}}
SONAR_TOKEN: ${{secrets.SONAR_TOKEN}}
run: mvn -B verify --file pom.xml -Pcoverage javadoc:javadoc sonar:sonar -Dsonar.organization=smallrye -Dsonar.projectKey=smallrye_smallrye-metrics -Dsonar.login=$SONAR_TOKEN -Dmaven.test.failure.ignore=true
path: testsuite/tck/target/surefire-reports-*
31 changes: 0 additions & 31 deletions .github/workflows/pre-release.yml

This file was deleted.

53 changes: 0 additions & 53 deletions .github/workflows/release.yml

This file was deleted.

2 changes: 2 additions & 0 deletions implementation/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
<scope>test</scope>
</dependency>

Expand All @@ -95,6 +96,7 @@
<dependency>
<groupId>org.glassfish</groupId>
<artifactId>jakarta.json</artifactId>
<version>2.0.1</version>
<scope>test</scope>
</dependency>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public void cleanUp() {
/**
* Drops a particular registry. If a reference to the same registry type
* is requested later, a new empty registry will be created for that purpose.
*
*
* @param type Type of registry that should be dropped.
*/
public static void drop(MetricRegistry.Type type) {
Expand Down
51 changes: 20 additions & 31 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<parent>
<groupId>io.smallrye</groupId>
<artifactId>smallrye-jakarta-parent</artifactId>
<version>34</version>
<version>38</version>
</parent>

<artifactId>smallrye-metrics-parent</artifactId>
Expand All @@ -42,6 +42,7 @@
<version.jakarta.servlet>5.0.0</version.jakarta.servlet>

<!-- For testing -->
<version.smallrye.testing>2.2.0</version.smallrye.testing>
<version.wildfly>26.0.0.Final</version.wildfly>

<sonar.coverage.jacoco.xmlReportPaths>${project.basedir}/../coverage/target/site/jacoco-aggregate/jacoco.xml</sonar.coverage.jacoco.xmlReportPaths>
Expand Down Expand Up @@ -90,6 +91,21 @@
<version>${version.jakarta.servlet}</version>
</dependency>

<dependency>
<groupId>io.smallrye.testing</groupId>
<artifactId>smallrye-testing-bom</artifactId>
<version>${version.smallrye.testing}</version>
<scope>import</scope>
<type>pom</type>
</dependency>
<dependency>
<groupId>io.smallrye.testing</groupId>
<artifactId>smallrye-testing-bom-tck</artifactId>
<version>${version.smallrye.testing}</version>
<scope>import</scope>
<type>pom</type>
</dependency>

<dependency>
<!-- This is the "real" dependency -->
<groupId>io.smallrye.config</groupId>
Expand All @@ -106,13 +122,6 @@
<scope>test</scope>
</dependency>

<dependency>
<groupId>org.jboss.weld.servlet</groupId>
<artifactId>weld-servlet-core</artifactId>
<version>${version.weld.core}</version>
<scope>test</scope>
</dependency>

<dependency>
<groupId>io.smallrye.common</groupId>
<artifactId>smallrye-common-annotation</artifactId>
Expand All @@ -124,29 +133,9 @@
<build>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-release-plugin</artifactId>
<version>${version.release.plugin}</version>
<configuration>
<autoVersionSubmodules>true</autoVersionSubmodules>
<tagNameFormat>@{project.version}</tagNameFormat>
<preparationGoals>verify</preparationGoals>
<pushChanges>false</pushChanges>
<localCheckout>true</localCheckout>
<remoteTagging>false</remoteTagging>
<arguments>-DskipTests ${release.arguments}</arguments>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
<version>${version.gpg.plugin}</version>
<configuration>
<gpgArguments>
<arg>--pinentry-mode</arg>
<arg>loopback</arg>
</gpgArguments>
</configuration>
<groupId>net.revelc.code</groupId>
<artifactId>impsort-maven-plugin</artifactId>
<version>1.8.0</version>
</plugin>
</plugins>
</build>
Expand Down
1 change: 1 addition & 0 deletions testsuite/extra/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,7 @@
<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
<version>4.13.2</version>
</dependency>
<dependency>
<groupId>org.jboss.arquillian.junit</groupId>
Expand Down

0 comments on commit 17d0d63

Please sign in to comment.