-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix KeyEncryptionAlgorithm ECDH-ES typos #741
Conversation
@giotsintsadze Thanks! Please rename the commit to be more informative and link the issue in the description |
Hello, here is my new commit, giotsintsadze@4cb9c39 i hope it will satisfies the current request |
Hi @giotsintsadze , there are currently 3 commits in this PR. Please squash them into a single commit. Please also link the issue #737 in the description of this PR. Thank you! |
@giotsintsadze You can get a single commit by running these git commands on your typo-fix branch:
and then force pushing to your remote. Let me know if you have any questions about this. Thanks |
Hey sorry for late, please check if it is done correctly |
@giotsintsadze Thanks for the PR. Looks like something has gone wrong now with the commit history, as it now shows 5 commits. At this stage I'd consider creating a new branch, and cherry-picking 4cb9c39, |
i will refork and make new PR than |
@sberyozkin Yes that sounds like a good approach now, @giotsintsadze if you decide to submit a new PR you can close this one. Thanks! |
Please check if it satisfies your requirements.