Explain in JWTCallerPrincipal#getName JavaDocs that this method may not return a unique principal name #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skyllarr
approved these changes
Oct 16, 2023
|
@sberyozkin just wondering why the javadoc of JsonWebToken#getName is not being updated instead to not mention uniqueness? |
|
@Skyllarr, good point, right now I'm not sure how eclipse/microprofile-jwt-auth#319 will be resolved, we may indeed end up adding the same kind of caution there, though a more energetic fix would be to remove a In general, everyone is concerned about breaking things at the spec level |
…ot return a unique principal name
sberyozkin
force-pushed
the
doc_principal_name_is_not_unique
branch
from
955597e to
04f8168
Compare
|
@sberyozkin makes sense, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #714