Allow @Query on POJO-methods, refs #704
#732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MethodName should be null (since no method is used) and fieldName should just be the fields name, without removing an get/is/set prefix. Could be used later to distinguish between direct field access an access by method. Signed-off-by: Yannick da Silva Bröker <[email protected]>
Signed-off-by: Yannick da Silva Bröker <[email protected]>
phillip-kruger
approved these changes
Apr 6, 2021
|
Yes please backport as well |
phillip-kruger
added a commit
that referenced
this pull request
Apr 6, 2021
|
Hi @ybroeker, hope you are well, seems this PR broke Quarkus in native mode :( I'll look at this a.s.a.p, but if you have an idea what the problem is, please share :) |
|
Apparently MethodHandles have to be enabled via an explicit flag in Graalvm 20.3 (at least the part that is used), and full support has only been added with 21.0 (oracle/graal#2761). It should be easy to replace MethodHandles in Can create a pull request later |
|
Great ! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to use
�@Queryon POJO-methods, so methods don't need to be prefixed withget/is.#704 should not be closed yet, native record support would still be desirable. But at least it allows to annotate components with
@Queryinstead of implementing additional getters.I'm not sure what the backport policy is, if desired I can add that to 1.0.x as well.