Fix #728: Use WeakHashMap to prevent memory leaks #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
approved these changes
Apr 6, 2021
There was a problem hiding this comment.
Maybe we could remove the map entry for the DataLoader ourselves at some point, but I'm not familiar with the lifecycle of DataLoader objects so I'm not sure when exactly we can do this, and I'd rather not assume too much about how graphql-java will behave. The solution with a weak map, while not necessarily the most efficient, looks at least safe enough, so I'm +1 on this
phillip-kruger
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the memory leak by using WeakHashMap.