Batch exception fix when unwrapping exception #619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by:Phillip Kruger <[email protected]>
Signed-off-by:Phillip Kruger <[email protected]>
|
@t1 - added a test and now also a fix ! I'll do a back port for 1.0.x |
phillip-kruger
changed the title
|
@t1 this PR is waiting for you .... please review :) |
t1
previously approved these changes
Jan 29, 2021
| @@ -48,10 +43,6 @@ public AbstractDataFetcher(Operation operation, Config config) { | |||
| this.argumentHelper = new ArgumentHelper(operation.getArguments()); | |||
| this.partialResultHelper = new PartialResultHelper(); | |||
| this.batchLoaderHelper = new BatchLoaderHelper(); | |||
| if (config != null && config.getUnwrapExceptions().isPresent()) { | |||
There was a problem hiding this comment.
I would do this with an ifPresent block, but that's just a matter of taste, I guess.
There was a problem hiding this comment.
This is being deleted :)
server/implementation/src/main/java/io/smallrye/graphql/execution/error/ExceptionHandler.java
Show resolved
Hide resolved
server/tck/src/test/java/io/smallrye/graphql/test/apps/batch/api/BatchApi.java
Outdated
Show resolved
Hide resolved
…pi/BatchApi.java Co-authored-by: Rüdiger zu Dohna <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #590
Signed-off-by:Phillip Kruger [email protected]