-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#282: get error extension code
from exception name or annotation
#295
#282: get error extension code
from exception name or annotation
#295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@andymc12 sorry to add changes to an already approved PR, but I thought that TCK tests would be a good idea to make it easier to later migrate to MP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, a few small changes please
server/api/src/main/java/io/smallrye/graphql/api/GraphQlErrorCode.java
Outdated
Show resolved
Hide resolved
...implementation/src/main/java/io/smallrye/graphql/execution/error/ExecutionErrorsService.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @t1 !
No description provided.