Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#282: get error extension code from exception name or annotation #295

Merged
merged 3 commits into from
Jun 19, 2020

Conversation

t1
Copy link
Collaborator

@t1 t1 commented Jun 18, 2020

No description provided.

andymc12
andymc12 previously approved these changes Jun 18, 2020
Copy link
Collaborator

@andymc12 andymc12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t1
Copy link
Collaborator Author

t1 commented Jun 19, 2020

@andymc12 sorry to add changes to an already approved PR, but I thought that TCK tests would be a good idea to make it easier to later migrate to MP.

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, a few small changes please

Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @t1 !

@phillip-kruger phillip-kruger merged commit e5213cc into smallrye:master Jun 19, 2020
@phillip-kruger phillip-kruger added this to the 1.0.4 milestone Jun 19, 2020
@t1 t1 deleted the #282-error-code-annotation branch June 20, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ability for users to add error code
3 participants