Ignoring testNestedRecordWithListWithMissingFieldInQuery due to JDK (21) bug #2240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartisk
reviewed
Dec 11, 2024
| @Test | ||
| public void testNestedRecordWithListWithMissingFieldInQuery() throws Exception { | ||
| if (System.getProperty("java.version").startsWith("21.")) { |
There was a problem hiding this comment.
This affects 22 too, could we make it safer and do something along the lines of
String major = Integer.valueOf(System.getProperty("java.version").split("\\.")[0]);
org.junit.Assume.assumeFalse("Skipping testNestedRecordWithListWithMissingFieldInQuery because of bug in JDK 21 and 22, see https://bugs.openjdk.org/browse/JDK-8320575",
major == 21|| major == 22);
?
mskacelik
force-pushed
the
java-21-test-ignore
branch
from
178060a to
e768f4f
Compare
mskacelik
force-pushed
the
java-21-test-ignore
branch
from
e768f4f to
f52cdd6
Compare
jmartisk
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2232
https://bugs.openjdk.org/browse/JDK-8320575