Change bean discovery mode to annotated in all beans.xml #1765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me run the tests for the wildfly graphql feature pack, that should be pretty quick (I'll just need to cherry-pick it into the 2.0.x branch, because we don't have a WildFly version that is compatible with 2.1 right now) |
|
Cool, it worked! |
jmartisk
approved these changes
Mar 1, 2023
|
Glad to hear that, thanks for checking! |
|
Thanks! We just had a release yesterday, but we'll make another one ~ next week or so |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up on the discussion in Quarkus issue quarkusio/quarkus#31378 (comment)
In short, a Quarkus app using graphql now logs warnings because graphql artifacts contains
beans.xmlwith discovery modeallwhich is unsupported in CDI Lite and in Quarkus/Arc.I quick scanned the sub modules containing
beans.xmland it seems that all classes meant to be beans already have bean defining annotations (although keep in mind I am very much unfamiliar with this project).The change seems to pass all tests in this repo and shouldn't affect Quarkus (since even up until now, Arc treated these JARs as
annotatedanyway).It would be nice to test this with some other container such as WFLY to see if we're good. @jmartisk what's the easiest way to verify that? Are there some WFLY tests we could run? If so, where can I find them?