1670 repeatable directives

[t1]

No description provided.

[t1]

Strange: DynamicClientSSLTest.serverAuthentication_correctTruststore fails with a timeout. @jmartisk: any idea?

[jmartisk]

I've seen this too, it seems to have started happening intermittently (like in 1 in 5 runs maybe). I need to look into why.
I restarted the job, perhaps it will pass this time.

[jmartisk]

Ok it passed this time. The WildFly test failure is expected because of the changes we're introducing here, it will need an update of the test in the wildfly-graphql-feature-pack repo.
I'll look a bit more into the changes tomorrow, but it looks good so far

[t1]

Now the FederationTestCase.testFederationMetadataInSchema fails, because the directive changed. I tried to fix it, but a local build fails, so I couldn't test it. Line 60 should read: .body(Matchers.containsString("type Product @extends @key(fields : \"id\")"));.

[jmartisk]

Yeah I can update that when upgrading the feature pack's codebase to a version that contains this change, thanks.
One of your commit messages says that you're updating the documentation, but I don't see that, could you add that?
See https://smallrye.io/smallrye-graphql/2.1.0.Beta1/federation/ - we need to, at least, update the schema snippet at the end

[t1]

The documentation update was only the descriptions of the federation annotations. I'll update the actual docs now; thanks reminding me.

[jmartisk]

Enabled by default is bad, IMO.
On the Quarkus side, I've already had a user complaining that they suddenly started seeing

type _Service {
  sdl: String!
}

in their application's schema after upgrading the Quarkus version, even though they don't have anything related to Federation in it, and it broke some of their tooling.
My plan is to make Quarkus detect automatically whether federation should be enabled by scanning through the application for any annotations from io.smallrye.graphql.api.federation, and enabling if found. Of course, you will be able to override this automatic enabling using configuration.

This behavior is Quarkus specific though. WildFly can probably implement something similar if we want. So I'm not sure what to write in the general SmallRye documentation, because it potentially depends on the runtime that you're using. If we make both Quarkus and WildFly behave this way, I would say we can describe this automatic enabling in the SmallRye documentation. WDYT?

[jmartisk]

So your current text is kinda correct in the sense that if you add a Federation annotation, it will appear in the schema, but it's wrong to say that "Federation is enabled by default", because we don't want to include the type _Service stuff by default. And we won't include federation directive type declarations in the schema either- I have submitted #1678 to address this (don't worry that the PR is to a different branch, I will forward/back-port everything once we merge this and that).

[t1]

The original suggestion to "enable" it by default was from @phillip-kruger, actually... where "enable" means automatic scanning, so the _service and _entities queries only appear when necessary. I thought this was already so... also in JEE containers.

[jmartisk]

Right now, with Quarkus, that stuff appears always by default, even when the application doesn't have any Federation in it. I am going to fix that.
Ok, re-reading your text after this clarification, I think it is fine. It will be enabled in the sense that if you add an annotation, you will get directives and queries. At least this is how it will work after some adjustments in Quarkus+WildFly.