Fix randomly failing SubscriptionHasToBeCancelledOnWebSocketCloseTestCase #1561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acanda
changed the title
|
@jmartisk the WF build fails with noclassdeffound. Can you check ? |
|
@phillip-kruger that's expected because wildfly hasn't upgraded to jandex 3 yet |
|
Ok cool, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SubscriptionHasToBeCancelledOnWebSocketCloseTestCase was randomly failing on my machine because the hard-coded sleeps were not long enough. I replaced the sleeps with awaits that wait until the things the test expects actually happen or fail when it takes too long.