Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default constructor for UnionType #1476

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

craig-day
Copy link
Contributor

When trying to pull the union type changes into quarkus, I ran into a build error

java.lang.RuntimeException: java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step io.quarkus.deployment.steps.MainClassBuildStep#build threw an exception: java.lang.RuntimeException: Unable to serialize objects of type class io.smallrye.graphql.schema.model.UnionType to bytecode as it has no default constructor

@phillip-kruger do you know if there is anything I could have done in this repo to prevent that from happening? Was a test missed somewhere?

@phillip-kruger phillip-kruger added this to the 1.6.2 milestone Jul 20, 2022
@phillip-kruger phillip-kruger merged commit 4adf0fd into smallrye:1.6.x Jul 20, 2022
@phillip-kruger
Copy link
Member

No not really. Typically once it's in Quarkus we have tests, but this is a bit of a chicken-egg problem

@phillip-kruger
Copy link
Member

Maybe we can release 1.6.2 so you can try an get this into Quarkus ?

@craig-day craig-day deleted the default-constructor branch July 21, 2022 15:18
@craig-day
Copy link
Contributor Author

I was able to use local maven with quarkus and got the tests running and passing. I'll link open a draft PR against quarkus to see if I'm missing anything.

@craig-day
Copy link
Contributor Author

The quarkus work is here: quarkusio/quarkus#26865

The tests all work locally now. I was looking for places where there are docs about GraphQL Interfaces and was going to add a section next to it about unions, but couldn't find any. Should I add docs about both unions and interfaces somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants