#400: Add support for GraphQL union type #1469
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I eagerly started with defining the spec, but also wanted to get an implementation done.
This adds support for creating GraphQL union types using an annotation
@Union
on a Java interface. I chose an empty Java interface so there would be an explicit layer of abstraction to represent the union itself.Example:
would create
An alternative could have been to directly annotate a type with the name of the union(s) it should be a member of, then generate the union from there.
Expand for alternative Java example
Event thought this is a little less code, I didn't like it because the
@Union
annotation no longer describes an object directly, rather a relationship between objects. This relationship now only exists in the world of strings, and has no concrete representation in code.For lots more thoughts, see the PR description here: eclipse/microprofile-graphql#459
Resolves #400