Mulitple cleanups in prep for non blocking #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
Signed-off-by: Phillip Kruger <[email protected]>
|
For the record, what did you do to 'fix' the testing SSL certificates? Does it need an update of |
|
Yes, this was weird. I had to re generate the certs using java 11, then if was fine for both 11 and 17. if i generate with 17 it breaks the build |
|
@jmartisk - please check the "Refactor subscriptions to use async and reuse common code" commit, thet needs some eyes. The other is fairly small clean up |
|
Quarkus failure is expected, needs a small api fix in Quarkus. Merging for now, we can roll forward if there are any issues |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains some cleanup on the way to get non blocking to work