Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Blocking/NonBlocking support #1300

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Adding Blocking/NonBlocking support #1300

merged 2 commits into from
Mar 9, 2022

Conversation

phillip-kruger
Copy link
Member

Here the highlevel changes:

  • Added support for Blocking and NonBlocking annotations
  • Added support for plugable DataFetchers
  • Deprecate request/response on ExecutionService in favour of providing a writer
  • Added option to execute async
  • Allow passing in of execution strategies
  • Changed BatchLoaderEnvironment to rather carry GraphQLContext vs SmallRyeContext

Context propagation is still very messy. Need to clean that up
Signed-off-by:Phillip Kruger [email protected]

@phillip-kruger
a fairly big change, mostly to allow non blocking from Quarkus.
b3d611b 
Here the highlevel changes:

- Added support for Blocking and NonBlocking annotations
- Added support for plugable DataFetchers
- Deprecate request/response on ExecutionService in favour of providing a writer
- Added option to execute async
- Allow passing in of execution strategies
- Changed BatchLoaderEnvironment to rather carry GraphQLContext vs SmallRyeContext

Context propagation is still very messy. Need to clean that up
Signed-off-by:Phillip Kruger <[email protected]>
@phillip-kruger phillip-kruger changed the title a fairly big change, mostly to allow non blocking from Quarkus. Adding Blocking/NonBlocking support Mar 7, 2022
@phillip-kruger phillip-kruger added this to the 1.5.0 milestone Mar 7, 2022
@jmartisk
Copy link
Member

jmartisk commented Mar 7, 2022

@phillip-kruger please rebase, this is missing some of the latest websocket changes, so it's hard to verify quarkus/wildfly compatibility
I'll see what can be done with wildfly now, seems tests are broken
By the way, for the quarkus upgrade to 1.4.4 (or 1.5.0...) I have this branch https://github.com/jmartisk/quarkus/tree/srgql-1.4.4 so any more Quarkus-side work might need to be based off that

@jmartisk
Copy link
Member

jmartisk commented Mar 7, 2022

FYI @phillip-kruger , WildFly tests are passing for me after rebasing your branch against main, and updating an outdated version of org.dataloader in the wildfly-graphql-feature-pack repo.. I'm using this branch https://github.com/jmartisk/wildfly-graphql-feature-pack/tree/srgql-1.4.4

@phillip-kruger
Copy link
Member Author

Thanks for checking. I am going to commit a few more changes and rebase. Thanks

@phillip-kruger phillip-kruger merged commit 9ac9626 into smallrye:main Mar 9, 2022
@phillip-kruger phillip-kruger mentioned this pull request Jul 20, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@phillip-kruger @jmartisk