-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#521: add federation to core: #1132
Conversation
@t1 In our project we got a working quarkus server with federation, with some technical tricks like working with a 2nd jandex index and manipulation of the schema in the federation gateway itself. |
8e2acae
to
9c62ec9
Compare
a606806
to
297f521
Compare
297f521
to
8294643
Compare
8294643
to
ae68ffc
Compare
ae68ffc
to
7678343
Compare
7678343
to
fac3651
Compare
fac3651
to
0d90a1f
Compare
b6b49fb
to
4448db5
Compare
@phillip-kruger & @johgoe : I think the core federation functionality should be working. I have some trouble to get my tests with the |
It works after updating Apollo to the latest version!!! So it was a bug. I shared my demo project: https://github.com/t1/smallrye-graphql-federation-demo I'll continue writing tests now. Comments welcome!!!!!!!1111 |
server/implementation/src/main/java/io/smallrye/graphql/bootstrap/Bootstrap.java
Outdated
Show resolved
Hide resolved
server/implementation/src/main/java/io/smallrye/graphql/bootstrap/FederationDataFetcher.java
Outdated
Show resolved
Hide resolved
76f53d9
to
c6b3a6d
Compare
Thanks @t1. I'll have a look a.s.a.p |
Is the documentation sufficient? |
Looks nice. Does it support mutiny return types? Would this already work with quarkus? Then we could test it with our services and see if we find anything. |
It probably should, but I haven't tried.
The quarkus tests fail with compile errors that I don't recognise immediately. |
I think this is complete now and could be merged. |
Hi @t1 - Thanks for this. I'll have a look as soon as I have a gap |
@jmartisk: it looks like @phillip-kruger is extremely busy with other things right now. maybe you can give some feedback? |
1cc3f34
to
55d8ff7
Compare
I'll look at this soon. This will need a thorough review and we need to see if this will work in Quarkus |
This could also use writing some Quarkus-side integration test coverage as part of doing the review (well, if possible - because running a real integration test seems to require a gateway and at least two Quarkus instances, which makes it very difficult) |
…-java-support` 2.0.5 to 2.0.6
dd3ea18
to
0a77d5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks @t1 - this is a big contribution ! If we can move that one part to the model, I think we are good to go !
server/implementation/src/main/java/io/smallrye/graphql/bootstrap/Bootstrap.java
Show resolved
Hide resolved
server/runner/src/main/resources/META-INF/microprofile-config.properties
Outdated
Show resolved
Hide resolved
@jmartisk - I am merging here. Can you help with creating a new 1.9.x branch and backport (non-Jakarata) to there ? Then I cal look at the jandex in that branch and once we are happy we can get this into Quarkus. Le me know |
@t1 Thanks for this massive contribution ! |
I'll create a 1.9.x branch with this that will target Quarkus 2.15, which is due some time in December or January, so we will have enough time to polish it. At minimum, I believe we should make the new dependency ( |
Bootstrap#fetchEntities
andBootstrap#fetchEntityType