Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for records as input on the server side #1045

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

jmartisk
Copy link
Member

@jmartisk jmartisk commented Sep 16, 2021

It's a bit hacky because usage of record as input now requires the user to annotate its canonical constructor with @JsonbCreator, or create another custom JsonbCreator in the record. Yasson, our JSON-B impl, does not support records properly yet, so this is very much best-effort.

Fixes #971

@jmartisk jmartisk added the Server This issue applies to the Server side label Sep 16, 2021
@jmartisk jmartisk force-pushed the main-issue-971-server branch from e047cd9 to dbc1405 Compare September 16, 2021 09:48
@jmartisk jmartisk force-pushed the main-issue-971-server branch from dbc1405 to 23aa62a Compare September 16, 2021 10:09
Copy link
Member

@phillip-kruger phillip-kruger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@phillip-kruger phillip-kruger added this to the 1.3.4 milestone Sep 16, 2021
@phillip-kruger phillip-kruger merged commit 3f21386 into smallrye:main Sep 16, 2021
@jmartisk jmartisk deleted the main-issue-971-server branch September 16, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Server This issue applies to the Server side
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend support for records
2 participants