Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static fields shouldn't be added to Types & Inputs #700

Closed
ybroeker opened this issue Mar 21, 2021 · 1 comment
Closed

static fields shouldn't be added to Types & Inputs #700

ybroeker opened this issue Mar 21, 2021 · 1 comment

Comments

@ybroeker
Copy link
Contributor

Currently, static fields are added to the schema on types and inputs, which means constants must be explicitly ignored.
Those fields should be ignored by default.

Especially for inputs, as these field cannot be used at runtime.
@phillip-kruger
Copy link
Member

Hi @ybroeker ! Welcome back :)

This is a valid point ! Are you looking to fix this ?

ybroeker added a commit to ybroeker/smallrye-graphql that referenced this issue Mar 31, 2021
@ybroeker
Add tests to check existence of fields with certain modifiers
3245cac 
refs smallrye#700, refs smallrye#701
ybroeker added a commit to ybroeker/smallrye-graphql that referenced this issue Mar 31, 2021
@ybroeker
Add tests to check existence of fields with certain modifiers
a65bc4d 
refs smallrye#700, refs smallrye#701
ybroeker added a commit to ybroeker/smallrye-graphql that referenced this issue Mar 31, 2021
@ybroeker
Add tests to check existence of fields with certain modifiers
366e970 
refs smallrye#700, refs smallrye#701

Signed-off-by: Yannick da Silva Bröker <[email protected]>
ybroeker added a commit to ybroeker/smallrye-graphql that referenced this issue Mar 31, 2021
@ybroeker
Fix smallrye#700, fix smallrye#701 Check modifiers while considering …
3eb37ab 
…a field and/or method as a graphql field.
phillip-kruger added a commit that referenced this issue Mar 31, 2021
@phillip-kruger
Merge pull request #719 from ybroeker/fix/fieldVisibility
9cefd20 
Fix #700, fix #701
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@phillip-kruger @ybroeker