Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom directive #628

Closed
phillip-kruger opened this issue Feb 3, 2021 · 3 comments
Closed

Support custom directive #628

phillip-kruger opened this issue Feb 3, 2021 · 3 comments
Labels
enhancement New feature or request Server This issue applies to the Server side

Comments

@phillip-kruger
Copy link
Member

see eclipse/microprofile-graphql#344
@t1 t1 mentioned this issue Feb 4, 2021
Open
@t1
Copy link
Collaborator

t1 commented Mar 27, 2021

@KSmigielski : I need this for #521. Have you already started? Otherwise I will start working on this now.

t1 added a commit to t1/smallrye-graphql that referenced this issue Mar 31, 2021
@t1
smallrye#628: custom directives on types (plus some power-annotations…
8df0ca1 
… cleanup)
@t1 t1 added enhancement New feature or request Server This issue applies to the Server side labels Apr 1, 2021
@t1 t1 added this to the 1.1.3 milestone Apr 1, 2021
phillip-kruger added a commit that referenced this issue Apr 4, 2021
@phillip-kruger
Merge pull request #721 from t1/628-custom-directives
0733c92 
#628: custom directives on types
@ybroeker ybroeker mentioned this issue Apr 6, 2021
Merged
@t1
Copy link
Collaborator

t1 commented Apr 7, 2021

We don't have full support, yet; just type directives. We at least need also field directives. I haven't considered the other possible locations and if they make sense in MP GraphQL. Reopening.

@t1 t1 reopened this Apr 7, 2021
@phillip-kruger phillip-kruger removed this from the 1.2.0 milestone Apr 15, 2021
@t1 t1 mentioned this issue May 19, 2021
Closed
t1 added a commit to t1/smallrye-graphql that referenced this issue May 25, 2021
@t1
smallrye#628: custom field directives
71eaf58
@t1
Copy link
Collaborator

t1 commented May 25, 2021

I think we can close this when #810 has been merged. If locations other than type and field become necessary in the future, we can open a new issue.

phillip-kruger added a commit that referenced this issue May 25, 2021
@phillip-kruger
Merge pull request #810 from t1/628-custom-field-directives
b381aa1 
#628: custom field directives
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Server This issue applies to the Server side
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@t1 @phillip-kruger