-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server records arrays and sets not working #1384
Comments
Thats not good. We probably need tests for this then, so that it doe not happen again. @robp94 you keen to do a PR ? |
Not sure if I have time for it. Maybe on the weekend. |
I've just hit this bug using latest Quarkus 2.9.2 Final release, which includes smallrye-graphql-1.4.5 It's pretty blocking since an API of ours does need passing in an array of strings according to the design requirement. I couldn't find any information about this fix being part of next Quarkus release. Do you have anything to share? Thanks. |
OK... I got my answer here: Quarkus 2.10 will include smallrye-graphql-1.6.0, which doesn't include this fix. 😐 |
Is there a fix ? Do you have the PR link for that fix ? Most things in 2.x is backported to 1.6.x. the only difference is the Jakarta namespace |
Isn't this the fix? |
O, I missed that. It does not seem to have the backport label, so probably not. @jmartisk w.d.y.t ? Can we backport this ? |
Should be in 1.6.x https://github.com/smallrye/smallrye-graphql/commits/1.6.x 9. May |
Yeah I think I backported that while I was checking that the branch has everything it should contain. Nevertheless, we should try to use the label to avoid forgetting in the future |
So this should be in Quarkus 2.10 |
With quarkus 2.8.2 arrays in records-inputs are always empty. This worked fine with 2.7.x.
They were usable fine with the @JsonbCreator workaround.
Reproducer:
code-with-quarkus-set.zip
The text was updated successfully, but these errors were encountered: