Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server records arrays and sets not working #1384

Closed
robp94 opened this issue May 5, 2022 · 10 comments · Fixed by #1385
Closed

Server records arrays and sets not working #1384

robp94 opened this issue May 5, 2022 · 10 comments · Fixed by #1385

Comments

@robp94
Copy link
Contributor

robp94 commented May 5, 2022

With quarkus 2.8.2 arrays in records-inputs are always empty. This worked fine with 2.7.x.

They were usable fine with the @JsonbCreator workaround.

Reproducer:
code-with-quarkus-set.zip

@phillip-kruger
Copy link
Member

Thats not good. We probably need tests for this then, so that it doe not happen again. @robp94 you keen to do a PR ?

@robp94
Copy link
Contributor Author

robp94 commented May 5, 2022

Not sure if I have time for it. Maybe on the weekend.

robp94 added a commit to robp94/smallrye-graphql that referenced this issue May 7, 2022
robp94 added a commit to robp94/smallrye-graphql that referenced this issue May 8, 2022
robp94 added a commit to robp94/smallrye-graphql that referenced this issue May 8, 2022
phillip-kruger added a commit that referenced this issue May 8, 2022
jmartisk pushed a commit that referenced this issue May 9, 2022
@tigerinus
Copy link

I've just hit this bug using latest Quarkus 2.9.2 Final release, which includes smallrye-graphql-1.4.5 It's pretty blocking since an API of ours does need passing in an array of strings according to the design requirement.

I couldn't find any information about this fix being part of next Quarkus release. Do you have anything to share?

Thanks.

@tigerinus
Copy link

OK... I got my answer here:

1.6.x...2.0.0.RC4

Quarkus 2.10 will include smallrye-graphql-1.6.0, which doesn't include this fix. 😐

@phillip-kruger
Copy link
Member

Is there a fix ? Do you have the PR link for that fix ? Most things in 2.x is backported to 1.6.x. the only difference is the Jakarta namespace

@tigerinus
Copy link

Is there a fix ? Do you have the PR link for that fix ? Most things in 2.x is backported to 1.6.x. the only difference is the Jakarta namespace

#1385

Isn't this the fix?

@phillip-kruger
Copy link
Member

O, I missed that. It does not seem to have the backport label, so probably not. @jmartisk w.d.y.t ? Can we backport this ?

@robp94
Copy link
Contributor Author

robp94 commented Jun 19, 2022

Should be in 1.6.x https://github.com/smallrye/smallrye-graphql/commits/1.6.x 9. May

@jmartisk
Copy link
Member

Yeah I think I backported that while I was checking that the branch has everything it should contain. Nevertheless, we should try to use the label to avoid forgetting in the future

@phillip-kruger
Copy link
Member

So this should be in Quarkus 2.10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants