Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SmallRyeCurrentThreadContextInterceptor: skip processing overhead when CP is disabled #309

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

Sanne
Copy link
Contributor

@Sanne Sanne commented Aug 31, 2021

No description provided.

FroMage
FroMage previously approved these changes Sep 1, 2021
@FroMage
Copy link
Contributor

FroMage commented Sep 1, 2021

OK, so what I said was bullshit:

     * {@link ThreadContext#ALL_REMAINING} is automatically appended to the
     * set of cleared context if neither the {@link #propagated} set nor the
     * {@link #unchanged} set include {@link ThreadContext#ALL_REMAINING}.

It's slightly more complex than what I claimed, so your initial change was better, even though it didn't account for crazy people listing every damn context in unchanged. Sorry about that :(

@Sanne
Copy link
Contributor Author

Sanne commented Sep 1, 2021

NP 👍 replaced with the original commit.

@FroMage FroMage merged commit 8df3d73 into smallrye:main Sep 1, 2021
@FroMage FroMage added this to the 1.2.2 milestone Sep 1, 2021
@FroMage FroMage added the enhancement New feature or request label Sep 1, 2021
@Sanne Sanne deleted the Fastpaths branch September 1, 2021 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants