Prevent CompleteableFuture$UniApply from being contextualized #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
previously approved these changes
Jan 15, 2021
core/src/main/java/io/smallrye/context/SmallRyeManagedExecutor.java
Outdated
Show resolved
Hide resolved
This class cannot be created by user core (it is package private in the JDK) and therefore will never need to be contextualized. This class is created by the JDK when completeableFuture.thenApplyAsync is used and without this PR, context propagation came into place twice: once for the function passed to the thenApplyAsync and once for the UniApply Runnable
geoand
force-pushed
the
uniapply-runnable
branch
from
1b83d22 to
756e463
Compare
manovotn
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class cannot be created by user code (it is package private in the JDK)
and therefore will never need to be contextualized.
This class is created by the JDK when completeableFuture.thenApplyAsync is used
and without this PR, context propagation came into place twice:
once for the function passed to the thenApplyAsync and once for the UniApply Runnable