Micro performance improvements #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f a single ThreadContextProviderPlan
|
Added a javadoc fix |
FroMage
approved these changes
Jan 12, 2021
|
Thanks @Sanne ! |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of these commits are small refactorings and should be semantically equivalent to the current code, but aim at overall savings in memory allocation rates.
Using Techempower, this PR improves the TLAB allocation rate of the Quarkus benchmark by about ~12% total when using the combination RestEasy Reactive + Hibernate Reactive.
Overall, it's all about avoiding allocations for short lived objects; in particular allocating iterators on the HashSet instances of
ThreadContextProviderPlanis very hot, and performance results suggest the JIT wasn't able to apply escape analysis optimisations in these cases.I'm not at all familiar with the codebase: code to be patched has been identified via profiling.