Skip to content

Commit

Permalink
Use JDK 17 to build
Browse files Browse the repository at this point in the history
  • Loading branch information
radcortez committed Sep 7, 2022
1 parent 1b8dbb2 commit 8144b31
Show file tree
Hide file tree
Showing 6 changed files with 10 additions and 26 deletions.
32 changes: 8 additions & 24 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,38 +22,22 @@ on:
jobs:
build:
runs-on: ubuntu-latest
name: build with JDK 12
strategy:
matrix:
java: [17]
name: build with jdk ${{matrix.java}}

steps:
- uses: actions/checkout@v2
name: checkout

# We want to be able to test with 8
- uses: actions/setup-java@v1
name: set up JDK 8
name: set up jdk ${{matrix.java}}
with:
java-version: 8

- name: Set JAVA_HOME_8 var
run: |
echo "JAVA_HOME_8=$JAVA_HOME" >> $GITHUB_ENV
# We need to build the project with at least this JDK version
- uses: actions/setup-java@v1
name: set up JDK 12
with:
java-version: 12

- name: Set JAVA_HOME_12 var
run: |
echo "JAVA_HOME_12=$JAVA_HOME" >> $GITHUB_ENV
java-version: ${{matrix.java}}

- name: build with maven
# The first run statement is theoretically redundant, but it's a safety latch in case multi JDK setup doesn't work
run: |
JAVA_HOME=${{ env.JAVA_HOME_12 }}
echo $JAVA_HOME
mvn -B formatter:validate verify --file pom.xml -Djava8.home=${{ env.JAVA_HOME_8 }} javadoc:javadoc
run: mvn -B formatter:validate verify --file pom.xml

quality:
needs: [build]
Expand All @@ -65,7 +49,7 @@ jobs:
- uses: actions/checkout@v2
- uses: actions/setup-java@v1
with:
java-version: 12
java-version: 17

- name: sonar
env:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:

- uses: actions/setup-java@v1
with:
java-version: 12
java-version: 17

- name: maven release ${{steps.metadata.outputs.current-version}}
run: |
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
<version.vertx>4.3.3</version.vertx>
<version.hamcrest>2.2</version.hamcrest>

<maven.javadoc.failOnWarnings>true</maven.javadoc.failOnWarnings>
<maven.javadoc.failOnWarnings>false</maven.javadoc.failOnWarnings>
</properties>

<developers>
Expand Down
Empty file removed tests/build-release-8
Empty file.
Empty file removed tests/build-test-java8
Empty file.
Empty file removed tests/build-test-java9
Empty file.

0 comments on commit 8144b31

Please sign in to comment.