Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add way to iterate config properties in ConfigSourceContext. #402

Merged
merged 2 commits into from
Sep 25, 2020

Conversation

radcortez
Copy link
Member

No description provided.

@vsevel
Copy link

vsevel commented Sep 24, 2020

hello @radcortez. I checked vault's code. I only need to iterate over properties names. so we should be fine with your improvement.

Copy link
Contributor

@Emily-Jiang Emily-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What issue is this PR trying to fix?

@radcortez
Copy link
Member Author

What issue is this PR trying to fix?

This is a part of our feature to provide a way to construct a ConfigSource with contextual information from other sources. We are not fixing anything in particular. We are just adding a way for implementors to access the current list of properties from other sources. This will allow to filter sources by a prefix.

@radcortez radcortez added this to the 1.9.1 milestone Sep 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants