Add the @Blocking and @NonBlocking annotations #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radcortez
previously approved these changes
Oct 19, 2020
Ladicek
reviewed
Oct 19, 2020
annotation/src/main/java/io/smallrye/common/annotation/Blocking.java
Outdated
Show resolved
Hide resolved
|
Converting the PR to a draft - there is a few investigations to do before merging. |
dmlloyd
previously approved these changes
Oct 19, 2020
cescoffier
force-pushed
the
blocking-non-blocking-annotations
branch
from
3a1eb96 to
38d9f33
Compare
Ladicek
reviewed
Oct 20, 2020
annotation/src/main/java/io/smallrye/common/annotation/NonBlocking.java
Outdated
Show resolved
Hide resolved
Ladicek
reviewed
Oct 20, 2020
annotation/src/main/java/io/smallrye/common/annotation/Blocking.java
Outdated
Show resolved
Hide resolved
Ladicek
reviewed
Oct 20, 2020
annotation/src/main/java/io/smallrye/common/annotation/Blocking.java
Outdated
Show resolved
Hide resolved
cescoffier
force-pushed
the
blocking-non-blocking-annotations
branch
from
38d9f33 to
26a8784
Compare
Ladicek
reviewed
Oct 20, 2020
|
Added just a few minor comments, LGTM in general. |
cescoffier
force-pushed
the
blocking-non-blocking-annotations
branch
3 times, most recently
from
6739824 to
f4b14de
Compare
|
@Ladicek I've addressed your comments (Thanks!) and added you as a co-author. |
Ladicek
previously approved these changes
Oct 20, 2020
|
I don't really feel like a co-author, but thanks! :-) |
mkouba
reviewed
Oct 20, 2020
annotation/src/main/java/io/smallrye/common/annotation/Blocking.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ladislav Thon <[email protected]>
cescoffier
force-pushed
the
blocking-non-blocking-annotations
branch
from
f4b14de to
8606110
Compare
Ladicek
approved these changes
Oct 20, 2020
|
@radcortez anything else required for this PR and getting a release? Need it for Quarkus 1.10 (still a bit of time, so no rush, but I just would like to address any issues soon enough (and avoid a final half-backed rush before the code freeze)). |
radcortez
approved these changes
Oct 21, 2020
|
Looks good to me too. I'll merge and push a release. |
|
Thanks @radcortez ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on the discussion from quarkusio/quarkus#12418.
Add the
@Blockingand@NonBlockingannotation.@Ladicek Can you check and comment?
@mkouba I dropped the Qualifier part for now (hopefully for good). I will see how I can work around this in Quarkus-gRPC (@michalszynkiewicz FYI).