Docker 3 #385
Open
Docker 3 #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegklimov
commented
Oct 23, 2024
| } | ||
| }); | ||
| } else { | ||
| error!("Failed to upgrade global context, cannot clean up docker container session"); |
There was a problem hiding this comment.
"shotdown detected, just quit"
olegklimov
commented
Oct 25, 2024
|
|
||
| RUN cargo build | ||
|
|
||
| RUN mkdir -p /output && cp target/debug/refact-lsp /output/ |
There was a problem hiding this comment.
hmm why /output ?
There was a problem hiding this comment.
The Dockerfile is primarily for building refact-lsp for development. We’ll extract the binary to the local machine. The /output directory is a bit generic, but I've seen it a few times; if you have a clearer name suggestion, we can rename it.
humbertoyusta
force-pushed
the
docker
branch
6 times, most recently
from
38f9036
to
9041fef
Compare
humbertoyusta
force-pushed
the
docker
branch
3 times, most recently
from
16cd255
to
9552cf2
Compare
…ntainer and expose to all interfaces only from container
…port yet, note the frontend is still calling it
…d whenever is necessary
…, and to sync to container
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.