-
-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add programming languages to 'Projects' #40
Feature: Add programming languages to 'Projects' #40
Conversation
Deploy request for gatsby-portfolio-dev pending review. Review with commit 97097a8 |
@benji011 is attempting to deploy a commit to a Personal Account owned by Ismail Ghallou on Vercel. @smakosh first needs to authorize it. |
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/smakosh/gatsby-portfolio-dev/1fqsk5x8e |
Hey @benji011 this looks cool actually, worried how it would look like when there are many, could you think of a way to handle the UI on that case? |
Hi @smakosh ! I thought about that so I set the condition to be I think setting just 1 may infact even be enough. Is this what you mean? |
Yup, correct! Let me review your code real quick |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the contribution @benji011 🚀
What
In https://portfolio.smakosh.com we have below:
Before
After
Why
I forked from this repo & added these changes and then figured this might be a cool thing to add here. If this is ok (or if it's not really needed) please let me know. Thanks!